Switch to design system tootips in tccp #8698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistergone
approved these changes
Dec 20, 2024
You're talking about the need to add We do have a precedent of going into the components directory for some things, e.g. https://github.com/cfpb/consumerfinance.gov/blob/main/cfgov/unprocessed/css/skip-nav.scss#L3, but I agree that doesn't seem great and have treated that as a discouraged pattern that we may want to refactor away from. That said, for the tooltips, since their JS has a separate export maybe the Sass should work that way too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that tooltips are available in the design system, we should use them instead of our own custom implementation in tccp. This does that.
Things to note:
forwardthe tooltip sass, so it has to be included specifically. I think this may be an oversight that we should correct in the design system index.scss, but I'll defer to @anselmbradfordTesting